On Fri, 5 Apr 2024 12:42:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> src/java.base/share/classes/java/net/ServerSocket.java line 264: >> >>> 262: * 0 and 65535, inclusive. >>> 263: * >>> 264: * @see StandardSocketOptions >> >> What would you think about dropping this link, and the link to SocketImpl >> from all the constructors, they aren't relevant for anyone reading this part >> of the docs. > > These constructors talk about the `{@code createSocketImpl} method`, so I'm > guessing the `@see java.net.SocketImpl` was meant to provide reference to the > `SocketImpl`. But I think we should just change the `{@code createSocketImpl} > method` to `{@link SocketImplFactory#createSocketImpl()} method` and remove > these `@see java.net.SocketImpl`. > > I guess we could do the same and remove the `@see java.net.SocketImpl` from > the constructors of `java.net.Socket` too? I've now updated the PR with what I had in mind for this proposed change to these constructors. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18646#discussion_r1553592558