On Fri, 17 May 2024 08:46:28 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this doc-only change which clarifies the value
>> type for the `java.net.SocketOptions.SO_LINGER` option?
>
> Jaikiran Pai has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reword based on Alan's suggestion
src/java.base/share/classes/java/net/SocketOptions.java line 196:
> 194: * Set the value to {@code Boolean.FALSE} or an integer less than
> {@code 0} with
> 195: * {@link #setOption(int, Object)} to disable this option. An
> integer greater than or equal to
> 196: * {@code 0} will enable the option and will represent the linger
> timeout.
In the referenced description is it "linger interval" rather than "linger
timeout" so I think we should use that here too. Otherwise looks okay.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19243#discussion_r1604770162
