On Fri, 17 May 2024 11:50:15 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have been deprecated since Java 1.2 and >> 1.4 days. They currently have replacement methods (noted in their javadoc) >> which have been in use for several releases. This commit updates these >> deprecated methods to deprecated for removal, to allow for their removal in >> a future release. >> >> No new tests have been added and existing tests in tier1, tier2 and tier3 >> continue to pass. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > also add forRemoval in internal classes I think DatagramSocketImpl.getTTL/setTTL will need to be deprecated for removal at the same time. Also I assume @Deprecated can be dropped from DatagramSocketAdaptor and NetMulticastSocket, they just override or call the deprecated methods so should only need `@SuppressWarnings("removal")`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19242#issuecomment-2119261576
