On Fri, Nov 18, 2016 at 1:54 PM, Florian Westphal <f...@strlen.de> wrote: > David Miller <da...@davemloft.net> wrote: >> If you really suspect that highspeed et al. need to implement their own >> undo_cwnd instead of using the default reno fallback, I would really >> rather that this gets either fixed or explicitly marked as likely wrong >> (in an "XXX" comment or similar). > > Ok, fair enough. I am not familiar with these algorithms, I will check > what they're doing in more detail and if absolutely needed resubmit this > patch with XXX/FIXME/TODO comments added.
BTW, FWIW I really like the idea of making undo_cwnd required. It simplifies the core code and forces CC modules to think about what undo should look like for their CC module. And I suspect you are right that those CC modules have an issue that should be fixed. neal