On Thu, Jul 27, 2017 at 11:00 AM, Sathya Perla <sathya.pe...@broadcom.com> wrote: > On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann <a...@arndb.de> wrote: > [...] >> >> On today's linux-next: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function >> `bnxt_dl_register': >> bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' >> bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register' >> bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free' >> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function >> `bnxt_dl_unregister': >> bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister' >> bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free' >> >> I think you are just missing a "depends on MAY_USE_DEVLINK" >> in INFINIBAND_BNXT_RE, which uses 'select BNXT'. >> >> This is a tricky corner case for Kconfig, where the MAY_USE_DEVLINK >> dependency is silently ignored for BNXT as long as MAY_USE_DEVLINK >> is not "=n". > > Can you pls share your .config so that I can reproduce this issue and > ensure that my fix really works...
The configuration I used happened to be for arm64, I've pasted it to https://pastebin.com/dl/rSJ6jCQM now. You should be able to reproduce it on x86 as well, with anything using CONFIG_NET_DEVLINK=m and INFINIBAND_BNXT_RE=y. Arnd