[
https://issues.apache.org/jira/browse/NUTCH-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560074#action_12560074
]
Andrzej Bialecki commented on NUTCH-152:
-----------------------------------------
Not applicable after this code was moved to Hadoop.
> TaskRunner io pipes are not setDaemon(true), cleanup and exception errors are
> incomplete, max heap too small
> ------------------------------------------------------------------------------------------------------------
>
> Key: NUTCH-152
> URL: https://issues.apache.org/jira/browse/NUTCH-152
> Project: Nutch
> Issue Type: Bug
> Components: fetcher
> Affects Versions: 0.8
> Environment: all
> Reporter: Paul Baclace
> Assignee: Andrzej Bialecki
> Fix For: 0.8
>
> Attachments: TaskRunner.java.patch
>
>
> 1. io pipes should be setDaemon(true) so that process cannot hang.
> 2. error messages for Exceptions are incomplete since e.getMessage() is used
> and it can be empty (NullPointerException has an empty message). Change
> this to e.toString() which always has more meaning.
> 3. a separate thread is not used for the subprocess stdout pipe, but it must
> be a separate thread if setDaemon(true).
> 4. TaskRunner.kill() does not stop the io pipe threads, but it should.
> 5. If InterruptedException occurs, it was assumed to be for the current
> (main) thread, but it should check this with Thread.interrupted() otherwise
> spurious thread interrupts will be rethrown as IOException.
> 6. A recent run had some Tasktracker child processes that ran out of heap.
> The default max heap size should be larger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
