aacid added a comment.
In https://phabricator.kde.org/D7671#143898, @rkflx wrote: > After further analysis, I can draw these conclusions (contradicting some assumptions from above, confirming others): > > 1. KDirWatch correctly emits at least one "dirty" each for directory watches when files are created, modified, deleted or moved_to (i.e., KDirWatch is not the reason for the bug). "Correctly" is an overstatement in my opinion, it should emit as many dirty as things that make it dirty, i.e. i disagree KDirWatch is not a reason for this bug (if we ignore possible races) > 2. The directory code path in Okular only works for deleted files, but never works for moved files (that's the real reason for the bug). > 3. The file code path in Okular would work, if KDirWatch emitted dirty for a file on move_to (but KDirWatch does not and should not). Again i disagree here, it's emitting a removed/added signal, so why wouldn't it emit dirty? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7671 To: progwolff, aacid Cc: sander, rkflx, #okular, aacid
