On Fri, 3 Nov 2023 16:45:14 +1030 Andrew Jeffery <and...@codeconstruct.com.au> wrote:
> struct kcs_bmc_device defines a spinlock member but the header in which > it is defined failed to include the spinlock header. In the spirit of > include-what-you-use, do what's necessary. > > Signed-off-by: Andrew Jeffery <and...@codeconstruct.com.au> This is fine, but whilst checking it I noticed there is no forwards def of struct device or appropriate include. Still that's unrelated Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> > --- > drivers/char/ipmi/kcs_bmc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/kcs_bmc.h b/drivers/char/ipmi/kcs_bmc.h > index fa408b802c79..880d835fb90c 100644 > --- a/drivers/char/ipmi/kcs_bmc.h > +++ b/drivers/char/ipmi/kcs_bmc.h > @@ -7,6 +7,7 @@ > #define __KCS_BMC_H__ > > #include <linux/list.h> > +#include <linux/spinlock.h> > > #define KCS_BMC_EVENT_TYPE_OBE BIT(0) > #define KCS_BMC_EVENT_TYPE_IBF BIT(1) _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
