On Fri, 2023-11-03 at 14:51 +0000, Jonathan Cameron wrote: > On Fri, 3 Nov 2023 16:45:19 +1030 > Andrew Jeffery <and...@codeconstruct.com.au> wrote: > > > KCS client modules may be removed by actions unrelated to KCS devices. > > As usual, removing a KCS client module requires unbinding all client > > instances from the underlying devices to prevent further use of the code. > > > > Previously, KCS client resource lifetimes were tied to the underlying > > KCS device instance with the use of `devm_k[mz]alloc()` APIs. This > > requires the use of `devm_free()` as a consequence. It's necessary to > > scrutinise use of explicit `devm_free()`s because they generally > > indicate there's a concerning corner-case in play, but that's not really > > the case here. Switch to explicit kmalloc()/kfree() to align > > expectations with the intent of the code. > > > > Signed-off-by: Andrew Jeffery <and...@codeconstruct.com.au> > Bit more unrelated white space stuff in here that ideally wouldn't be there.
Ack, I'll address that for v2. > Otherwise makes sense to me. > > Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Thanks, Andrew _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
