On Thu, 23 Feb 2023 11:28:56 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> 
wrote:

>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore 
>> this scroll event type, deltas are sent to java with the value equal to zero.
>> 
>> Here's whats happening:
>> 
>> We include all event masks, so when using gtk3 (>= 3.4.0) it includes 
>> `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  
>> `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction 
>> (UP/DOWN).
>> 
>> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we 
>> ignored it causing it to send deltas (x,y) = 0.
>> 
>> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, 
>> also adding smooth scroll functionality.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix direction

It works with me now.

-------------

Marked as reviewed by gl...@github.com (no known OpenJDK username).

PR: https://git.openjdk.org/jfx/pull/1044

Reply via email to