On Fri, 24 Feb 2023 09:49:33 GMT, Dean Wookey <dwoo...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 366:
>>
>>> 364: public boolean equals(Object o) {
>>> 365: if (this == o) return true;
>>> 366: if (o == null || !(o instanceof
>>> IdentityWrapperListChangeListener)) return false;
>>
>> (o instanceof IdentityWrapperListChangeListener) should take care of the
>> null case.
>> if(o instanceof IdentityWrapperListChangeListener that) {
>> return innerList == that.innerList;
>> }
>> return false;
>>
>> And also, could we have curly braces in all the if statements please?
>
> In general should we use new syntax like that instanceof syntax? JavaFX
> requires Java 17 now, but if changes were to be backported then using the new
> syntax makes it a bit more difficult.
that will be "SEP" (someone else's problem) ;-)
fx requires jdk17 as a boot jdk per JDK-8276144
-------------
PR: https://git.openjdk.org/jfx/pull/1037
