On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass > `Material`). Except for the introduction, I divided the documentation into 3 > sections: qualitative explanation, mathematical model (I wouldn't think it > necessary, but the current doc explains it), and examples. > > The reason for the verbosity of the doc is that I envisioned 2 target > audiences for this class. One is a Java developer who wants to understand the > terminology and workings of computer graphics or of the artists who are > already familiar with this domain. (How many Java developers know what > diffuse, specular and normal maps are?) The other is an artist who is already > familiar with the domain, but wants to see how this class compares with other > renderers. For this reason, I looked at the terminology used by engines like > Blender, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for reviewers and get this > into 22. This pull request has now been integrated. Changeset: d9645730 Author: Nir Lisker <nlis...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1 Stats: 521 lines in 39 files changed: 461 ins; 13 del; 47 mod 8314147: Updated the PhongMaterial documentation Reviewed-by: arapte, kcr ------------- PR: https://git.openjdk.org/jfx/pull/1378
