On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are > no longer needed. > > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I > changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it > doesn't matter much (`IDirect3DDevice9Ex` inherits `IDirect3DDevice` - it was > leveraged to transparently use the Ex device in the backend) but now we don't > have the non-Ex device, so that keeps it a bit more consistent and clear IMO. > > Verified by running tests on Windows 11, did not notice any regressions. > Unfortunately I have no way to test this on older systems. I tried to run the 3DLighting application and I'm getting an error. However, it looks like it's not this patch that is causing it since going back a few commits also gives this error. The jfx22 branch doesn't have this issue so it will take some investigation to find out what's going on. I'm on Win 10. # # A fatal error has been detected by the Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x000001b44b9ad260, pid=6332, tid=18096 # # JRE version: OpenJDK Runtime Environment (21.0.1+12) (build 21.0.1+12-29) # Java VM: OpenJDK 64-Bit Server VM (21.0.1+12-29, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64) # Problematic frame: # J 170 c2 java.lang.String.length()I java.base@21.0.1 (11 bytes) @ 0x000001b44b9ad260 [0x000001b44b9ad220+0x0000000000000040] # # No core dump will be written. Minidumps are not enabled by default on client versions of Windows # # An error report file with more information is saved as: # C:\Users\Nir\git\jfx\tests\performance\3DLighting\hs_err_pid6332.log [5.830s][warning][os] Loading hsdis library failed # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # ------------- PR Comment: https://git.openjdk.org/jfx/pull/1445#issuecomment-2076903265
