On Wed, 15 May 2024 19:53:43 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> README-code-reviews.md line 68: >> >>> 66: * Consider any compatibility concerns >>> 67: * Check whether there is an automated test; if not, ask for one, if it >>> is feasible >>> 68: * Make sure that the PR has executed the GHA tests and that they all >>> pass; if they aren't being run, ask the PR author to enable GHA workflows >> >> These tests sometimes fail and we integrate anyway. I noticed that sometimes >> they need a few iterations to succeed. Are we really dependent on them? >> >> Edit: currently the Linux test is failing, and this PR can't be the reason. > > or is it? :-) Isn't this automatic? Seems weird you could integrate without these passing. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602186713
