Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email )
Change subject: Print SSL peer signature information in handshake debug details ...................................................................... Patch Set 7: (2 comments) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/365/comment/3b343ee7_423d9351 : PS5, Line 2166: openvpn_snprintf(buf, buflen, ", peer temporary key: %s", > This probably belongs in the previous commit. Done File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/365/comment/be8eca11_de41140b : PS7, Line 2214: const char *peer_sig_type = ""; With libressl or openssl 1.0.2 this will print "" for now. Should we maybe change the default to "UNKNOWN" or something similar? Or would you consider that useless clutter? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib5fc0c4b8f164596681ac5ad73002068ec6de1e5 Gerrit-Change-Number: 365 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 09 Oct 2023 10:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
