On Wed, Jul 26, 2017 at 12:06 AM, Ilya Maximets <i.maxim...@samsung.com> wrote:
> On 25.07.2017 21:39, Andy Zhou wrote:
>> Commit 42781e77035d (bond: Unify hash functions in hash action and entry
>> lookup.) changed the BM_TCP's hash function, but did not update
>> hash mask fields accordingly.  Found by inspection.
>>
>> CC: Ilya Maximets <i.maxim...@samsung.com>
>> Signed-off-by: Andy Zhou <az...@ovn.org>
>> ---
>
> Good catch. I forget about this.
> One minor comment below, but it's not important.
>
> Acked-by: Ilya Maximets <i.maxim...@samsung.com>

Thanks for the review. Pushed.

>> +            flow_mask_hash_fields(flow, wc,
>> +                                  NX_HASH_FIELDS_SYMMETRIC_L3L4_UDP);
>
> Above function call, actually, fits in 79 characters limit and can be
> written in one line.
>
You are right. Thanks. I merged those two lines before pushing.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to