Thanks Jacob and Ales. I fixed the subject line and fixed the typo below
(as well as s/referances/references/) and pushed both patches in the
series to main.
On 3/28/24 05:04, Ales Musil wrote:
On Tue, Mar 26, 2024 at 5:32 PM Jacob Tanenbaum <jtane...@redhat.com> wrote:
Hi Jacob,
thank you for the v2. As 0-day suggests the commit subject should stat with
capital letter.
the testing was changed to remove the hardcoded table numbers from
flows. Two referances to table=28 where missed, this patch corrects that
typo: s/where/were/
and adds the correct variable name to the flow.
Fixes: f614335abca1 ("tests: Remove table numbers from "action parsing".")
This should be:
Fixes: 180749965eda ("tests: Use the ovn-debug binary to determine table
numbers.")
Signed-off-by: Jacob Tanenbaum <jtane...@redhat.com>
---
v2: addressed formatting seen by the day-0 bot and an additional referance
to table=28 was identified
diff --git a/tests/ovn.at b/tests/ovn.at
index f04b74210..d269077ac 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -22070,7 +22070,7 @@ check_row_count Port_Binding 1
logical_port=sw0-vir virtual_parent=sw0-p1
wait_for_ports_up sw0-vir
check ovn-nbctl --wait=hv sync
AT_CHECK([test 2 = `cat hv1/ovn-controller.log | grep "pinctrl received
packet-in" | \
-grep opcode=BIND_VPORT | grep OF_Table_ID=28 | wc -l`])
+grep opcode=BIND_VPORT | grep OF_Table_ID=$(ovn-debug
lflow-stage-to-oftable ls_in_arp_rsp) | wc -l`])
wait_row_count Port_Binding 1 logical_port=sw0-vir6 chassis=$hv1_ch_uuid
check_row_count Port_Binding 1 logical_port=sw0-vir6 virtual_parent=sw0-p1
@@ -37684,7 +37684,7 @@ tpa=$(ip_to_hex 10 0 0 10)
send_garp 1 1 $eth_src $eth_dst $spa $tpa
OVS_WAIT_UNTIL([test 1 = `cat hv1/ovn-controller.log | grep "pinctrl
received packet-in" | \
-grep opcode=BIND_VPORT | grep OF_Table_ID=28 | wc -l`])
+grep opcode=BIND_VPORT | grep OF_Table_ID=$(ovn-debug
lflow-stage-to-oftable ls_in_arp_rsp) | wc -l`])
sleep_controller hv1
--
2.42.0
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Other than those minor things it looks good, let's wait with v3 as I think
maintainers might be willing to amend those changes in during merge.
Acked-by: Ales Musil <amu...@redhat.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
