On Tue, Nov 15, 2022 at 11:39:20AM +0100, Daniel Gustafsson wrote: > + /* write given data to the page */ > + strncpy(TestSlruCtl->shared->page_buffer[slotno], data, BLCKSZ - 1); > > Would it make sense to instead use pg_pwrite to closer match the code being > tested?
Hmm. I am not exactly sure what we'd gain with that, as it would imply that we need to write directly to the file using SlruFileName() after doing ourselves a OpenTransientFile(), duplicating what SlruPhysicalWritePage() does to create a fd to feed to a pg_pwrite()? Or I misunderstood your point. -- Michael
signature.asc
Description: PGP signature
