On Wed, Nov 16, 2022 at 6:55 PM Maxim Orlov <orlo...@gmail.com> wrote: > >> These functions are marked as 'STRICT', meaning a null is returned, >> without even calling the function, if any of the input parameters is >> null. I think we can keep the behaviour the same as its friends. > > Thanks for the explanations. I think you are right. > > Confirm. And a timeline_id is added. >> >> While on this, I noticed that the pg_walfile_name_offset() isn't >> covered in tests. I took an opportunity and added a simple test case >> along with pg_walfile_offset_lsn(). >> >> I'm attaching the v3 patch set for further review. > > Great job! We should mark this patch as RFC, shall we?
Please do, if you feel so. Thanks for your review. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
