On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson <dan...@yesql.se> wrote: >> On 17 Nov 2022, at 08:06, Japin Li <japi...@hotmail.com> wrote: > >> I find some typo about xl_running_xacts in comments. >> Attached a patch to fix those. > > Thanks, applied! > >> - * might look that we could use xl_running_xact's ->xids information to >> + * might look that we could use xl_running_xacts->xids information to > > I'm not a native english speaker, but since xl_running_xacts refers to a name > in this case and not an indication of plural possession, ending with a 's is > correct even if it ends with an 's', so I instead changed this to > "xl_running_xacts's".
Thanks, I found other places use "xl_running_xacs'", such as "xl_running_xacts' oldestRunningXid" in snapbuild.c. -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd.