On Thu, Nov 17, 2022 at 2:55 AM Simon Riggs <simon.ri...@enterprisedb.com> wrote: > No, it will have a direct effect only on people using promote_trigger_file > who do not read and act upon the deprecation notice before upgrading > by making a one line change to their failover scripts.
TBH, I wonder if we shouldn't just nuke promote_trigger_file. pg_promote was added in 2018, and pg_ctl promote was added in 2011. So even if we haven't said promote_trigger_file was deprecated, it hasn't been the state-of-the-art way of doing this in a really long time. If we think that there are still a lot of people using it, or if popular tools are relying on it, then perhaps a deprecation period is warranted anyway. But I think we should at least consider the possibility that it's OK to just get rid of it right away. -- Robert Haas EDB: http://www.enterprisedb.com