On Wed, Dec 14, 2022 at 2:32 AM Nitin Jadhav <nitinjadhavpostg...@gmail.com> wrote: > In order to fix this, the > PendingCheckpointerStats.buf_written_checkpoints should be incremented > in SlruInternalWritePage() similar to > CheckpointStats.ckpt_bufs_written. I have attached the patch for the > same. Please share your thoughts.
Presumably we could make this consistent either by counting SLRU writes in both places, or by counting them in neither place. This proposal would count them in both places. But why is that the right thing to do? I'm somewhat inclined to think that we should use "buffers" to mean regular data buffers, and if SLRU buffers also need to be counted, we ought to make that a separate counter. Or just leave it out altogether. This is arguable, though, for sure.... -- Robert Haas EDB: http://www.enterprisedb.com
