On Thu, Dec 22, 2022 at 6:19 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Dec 22, 2022 at 12:47 PM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > > > On Thu, Dec 22, 2022 at 4:05 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > > I think > > > instead of adding new tests with this patch, it may be better to > > > change some of the existing tests related to streaming to use this > > > parameter as that will clearly show one of the purposes of this patch. > > > > +1. I think test_decoding/sql/stream.sql and spill.sql are good > > candidates and we change logical replication TAP tests in a separate > > patch. > > > > I prefer the other way, let's first do TAP tests because that will > also help immediately with the parallel apply feature. We need to > execute most of those tests in parallel mode.
Good point. Or we can do both if changes for test_decoding tests are not huge? Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com