On Sat, 7 Jan 2023 at 00:36, Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Fri, Jan 06, 2023 at 06:52:33PM +0000, Dean Rasheed wrote: > > > > So I think we should use the same SQL clauses as every other psql > > command that supports "S", namely: > > > > if (!showSystem && !pattern) > > appendPQExpBufferStr(&buf, " AND n.nspname <> 'pg_catalog'\n" > > " AND n.nspname <> > > 'information_schema'\n"); > > Good catch. I should have noticed this. The deleted comment mentions that > the system/temp tables normally aren't very interesting from a permissions > perspective, so perhaps there is an argument for always excluding temp > tables without a pattern. After all, \dp always excludes indexes and TOAST > tables. However, it looks like \dt includes temp tables, and I didn't see > any other meta-commands that excluded them. >
It might be true that temp tables aren't usually interesting from a permissions point of view, but it's not hard to imagine situations where interesting things do happen. It's also probably the case that most users won't have many temp tables, so I don't think including them by default will be particularly intrusive. Also, from a user perspective, I think it would be something of a POLA violation for \dp[S] and \dt[S] to include different sets of tables, though I appreciate that we do that now. There's nothing in the docs to indicate that that's the case. Anyway, I've pushed the v2 patch as-is. If anyone feels strongly enough that we should change its behaviour for temp tables, then we can still discuss that. Regards, Dean
