On Tue, Dec 27, 2022 at 09:56:10AM +0100, Peter Eisentraut wrote: > Refactor recordExtObjInitPriv(): Instead of half a dozen of > mostly-duplicate conditional branches, write one common one that can handle > most catalogs. We already have all the information we need, such as which > system catalog corresponds to which catalog table and which column is the > ACL column.
This seems reasonable. > + /* This will error on unsupported classoid. */ > + else if (get_object_attnum_acl(classoid)) nitpick: I would suggest explicitly checking that it isn't InvalidAttrNumber instead of relying on it always being 0. > - classoid == AggregateRelationId || I noticed that AggregateRelationId isn't listed in the ObjectProperty array, so I think recordExtObjInitPriv() will begin erroring for that classoid instead of ignoring it like we do today. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
