On Tue, Jan 17, 2023 at 07:55:53PM +0530, Bharath Rupireddy wrote: > On Tue, Jan 17, 2023 at 12:31 PM Michael Paquier <mich...@paquier.xyz> wrote: >> Oops. It looks like you are right here. This would impact the >> calculation of CheckPointSegments on reload when >> checkpoint_completion_target is updated. This is wrong since we've >> switched to max_wal_size as of 88e9823, so this had better be >> backpatched all the way down. >> >> Thoughts? > > +1 to backpatch as setting checkpoint_completion_target will not take > effect immediately.
Okay, applied down to 11. I have double-checked the surroundings to see if there was a similar mistake or something hiding around CheckpointSegments but noticed nothing (also did some primary/standby pgbench-ing with periodic reloads of checkpoint_completion_target, while on it). -- Michael
signature.asc
Description: PGP signature
