Hi Pavel, On Mon, Jan 16, 2023 at 9:10 AM Pavel Stehule <pavel.steh...@gmail.com> wrote:
> > > ne 15. 1. 2023 v 7:32 odesÃlatel Pavel Stehule <pavel.steh...@gmail.com> > napsal: > >> Hi >> >> >>> On Thu, Jan 12, 2023 at 9:51 AM Pavel Stehule <pavel.steh...@gmail.com> >>> wrote: >>> >>>> Hi >>>> >>>> I checked this patch and it looks well. All tests passed. Together with >>>> https://commitfest.postgresql.org/41/4013/ it can be a good feature. >>>> >>>> I re-tested impact on performance and for the worst case looks like >>>> less than 1% (0.8%). I think it is acceptable. Tested pgbench scenario >>>> "SELECT 1" >>>> >>>> pgbench -f ~/test.sql -C -c 3 -j 5 -T 100 -P10 postgres >>>> >>>> 733 tps (master), 727 tps (patched). >>>> >>>> I think raising an exception inside should be better tested - not it is >>>> only in 001_stream_rep.pl - generally more tests are welcome - there >>>> are no tested handling exceptions. >>>> >>> >> Thank you >> >> check-world passed without problems >> build doc passed without problems >> I think so tests are now enough >> >> I'll mark this patch as ready for committer >> > > Unfortunately, I forgot one important point. There are not any tests > related to backup. > > I miss pg_dump related tests. > > I mark this patch as waiting on the author. > > Thanks for noticing this. I have added sections to pg_dump tests. Attached v37 patch contains these additions along with the fresh rebase on master. -- best regards, Mikhail A. Gribkov e-mail: youzh...@gmail.com *http://www.flickr.com/photos/youzhick/albums <http://www.flickr.com/photos/youzhick/albums>* http://www.strava.com/athletes/5085772 phone: +7(916)604-71-12 Telegram: @youzhick >>>> >>>>
v37-On_client_login_event_trigger.patch
Description: Binary data
