> I want to note that the Fisher-Yates algorithm is implemented in a > difficult to understand manner. > +if (j < i) /* avoid fetching undefined data if j=i */ > This stuff does not make sense in case of shuffling arrays inplace. It > is important only for making a new copy of an array and only in > languages that cannot access uninitialized values. I'd suggest just > removing this line (in both cases).
Done. Also added another patch to remove the same check from another place in the codebase where it is unnecessary.
v10-0003-Support-load-balancing-in-libpq.patch
Description: Binary data
v10-0002-Refactor-libpq-to-store-addrinfo-in-a-libpq-owne.patch
Description: Binary data
v10-0004-Remove-unnecessary-check-from-Fisher-Yates-imple.patch
Description: Binary data
v10-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch
Description: Binary data
