RE: Rework LogicalOutputPluginWriterUpdateProgress

Fri, 10 Mar 2023 01:32:55 -0800 

On Mon, Mar 10, 2023 11:56 AM Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Wed, Mar 8, 2023 at 8:24 AM wangw.f...@fujitsu.com
> <wangw.f...@fujitsu.com> wrote:
> >
> > Attach the new patch.
> >
> 
> I think this combines multiple improvements in one patch. We can
> consider all of them together or maybe it would be better to split
> some of those. Do we think it makes sense to split some of the
> improvements? I could think of below:
> 
> 1. Remove SyncRepRequested() check from WalSndUpdateProgress().
> 2. Add check of wal_sender_timeout > 0 in WalSndUpdateProgress() and
> any other similar place.
> 3. Change the name of ProcessPendingWrites() to WalSndSendPending().
> 4. Change WalSndUpdateProgress() to WalSndUpdateProgressAndKeepalive().
> 5. The remaining patch.

I think it would help to review different improvements separately, so I split
the patch as suggested.

Also addressed the comments by Kuroda-san, Osumi-san and Peter.
Attach the new patch set.

Regards,
Wang wei

Attachment: v7-0001-Remove-SyncRepRequested-check-from-WalSndUpdatePr.patch
Description: v7-0001-Remove-SyncRepRequested-check-from-WalSndUpdatePr.patch

Attachment: v7-0002-Check-wal_sender_timeout-is-in-effect-before-usin.patch
Description: v7-0002-Check-wal_sender_timeout-is-in-effect-before-usin.patch

Attachment: v7-0003-Rename-the-function-ProcessPendingWrites-to-WalSn.patch
Description: v7-0003-Rename-the-function-ProcessPendingWrites-to-WalSn.patch

Attachment: v7-0004-Rename-the-function-WalSndUpdateProgress-to-WalSn.patch
Description: v7-0004-Rename-the-function-WalSndUpdateProgress-to-WalSn.patch

Attachment: v7-0005-Rework-LogicalOutputPluginWriterUpdateProgressAnd.patch
Description: v7-0005-Rework-LogicalOutputPluginWriterUpdateProgressAnd.patch

Attachment: v7-0006-Catch-the-absence-of-commit-rollback_prepared_cb_.patch
Description: v7-0006-Catch-the-absence-of-commit-rollback_prepared_cb_.patch

Reply via email to