On Tue, Apr 18, 2023 at 11:51 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: > > One thing I think we should do in this area is introduce #defines for > > all the message type codes and use those instead of having hard-coded > > constants everywhere. > > +1, but I wonder where we should put those exactly. My first thought > was postgres_ext.h, but the charter for that is > > * This file contains declarations of things that are visible everywhere > * in PostgreSQL *and* are visible to clients of frontend interface > libraries. > * For example, the Oid type is part of the API of libpq and other libraries. > > so picayune details of the wire protocol probably don't belong there. > Maybe we need a new header concerned with the wire protocol?
Yeah. I sort of thought maybe one of the files in src/include/libpq would be the right place, but it doesn't look like it. -- Robert Haas EDB: http://www.enterprisedb.com
