On Thu, Jun 8, 2023 at 7:35 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > o.tselebrovs...@postgrespro.ru writes: > > While working on an extension I've found an error in how length of > > encoded base64 string is calulated; > > Yeah, I think you're right. It's not of huge significance, because > it just overestimates by 1 or 2 bytes, but we might as well get > it right. Thanks for the report and patch!
>From your commit d98ed080bb > This bug is very ancient, dating to commit 79d78bb26 which > added encode.c. (The other instances were presumably copied > from there.) Still, it doesn't quite seem worth back-patching. Is it worth investing time in trying to unify these 3 occurrences of base64 length (and possibly other relevant) code to one place? If yes, I can volunteer for it. The common code facility under src/common/ did not exist back when pgcrypto was added, but since it does now, it may be worth it make others depend on implementation in src/common/ code. Best regards, Gurjeet http://Gurje.et
