On Tue, 2023-06-13 at 14:12 -0700, Nathan Bossart wrote: > I've been reviewing ff9618e lately, and I'm wondering whether it has > the > same problem that 19de0ab solved. Specifically, ff9618e introduces > has_partition_ancestor_privs(), which is used to check whether a user > has > MAINTAIN on any partition ancestors. This involves syscache lookups, > and > presently this function does not take any relation locks. I did > spend some > time trying to induce cache lookup errors, but I didn't have any > luck. > However, unless this can be made safe without too much trouble, I > think I'm > inclined to partially revert ff9618e, leaving the TOAST-related parts > intact.
Agreed. Having it work on partition hierarchies is a nice-to-have, but not central to the usability of the feature. If it's causing problems, best to take that out and reconsider in 17 if worthwhile. Regards, Jeff Davis