On Tue, Jul 4, 2023 at 7:15 PM David Rowley <dgrowle...@gmail.com> wrote:
> On Tue, 4 Jul 2023 at 20:12, Richard Guo <guofengli...@gmail.com> wrote: > > The v4 patch looks good to me (maybe some cosmetic tweaks are still > > needed for the comments). I think it's now 'Ready for Committer'. > > I agree. I went and hit the comments with a large hammer and while > there also adjusted the regression tests. I didn't think having "t" as > a table name was a good idea as it seems like a name with a high risk > of conflicting with a concurrently running test. Also, there didn't > seem to be much need to insert data into that table as the tests > didn't query any of it. > > The only other small tweak I made was to not call list_copy_head() > when the list does not need to be shortened. It's likely not that > important, but if the majority of cases are not partial matches, then > we'd otherwise be needlessly making copies of the list. > > I pushed the adjusted patch. The adjustments improve the patch a lot. Thanks for adjusting and pushing the patch. Thanks Richard
