On 2023-Jul-05, Amit Kapila wrote: > I think after returning "???" from logicalrep_message_type(), the > above is possible when we get the error: "invalid logical replication > message type "X"" from apply_dispatch(), right? If so, then what about > the case when we forgot to handle some message in > logicalrep_message_type() but handled it in apply_dispatch()? Isn't it > better to return the 'action' from the function > logicalrep_message_type() for unknown type? That way the information > could be a bit better and we can easily catch the code bug as well.
Are you suggesting that logicalrep_message_type should include the numerical value of 'action' in the ??? message? Something like this: ERROR: invalid logical replication message type "X" CONTEXT: processing remote data for replication origin "pg_16638" during message type "??? (123)" in transaction 796, finished at 0/16266F8 I don't see why not -- seems easy enough, and might help somebody. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ Tom: There seems to be something broken here. Teodor: I'm in sackcloth and ashes... Fixed. http://postgr.es/m/482d1632.8010...@sigaev.ru
