On Tue, Jul 11, 2023 at 5:31 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are my comments for v4. > > ====== > > Docs/Comments: > > All the docs and updated comments LTGM, except I felt one sentence > might be written differently to avoid nested parentheses. > > BEFORE > ...used for REPLICA IDENTITY FULL table (see > FindUsableIndexForReplicaIdentityFull() for details). > > AFTER > ...used for REPLICA IDENTITY FULL table. See > FindUsableIndexForReplicaIdentityFull() for details. > > ====
Agreed. I've attached the updated patch. I'll push it barring any objections. > > Logic: > > What was the decision about the earlier question [1] of > removing/merging the function IsIndexOnlyOnExpression()? > I don't think we have concluded any action for it. I agree that IsIndexOnlyOnExpression() is redundant. We don't need to check *all* index fields actually. I've attached a draft patch. It removes IsIndexOnlyOnExpression() and merges RemoteRelContainsLeftMostColumnOnIdx() to FindUsableIndexForReplicaIdentityFull. One concern is that we no longer do the assertion check with IsIndexUsableForReplicaIdentityFull(). What do you think? Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v5-0001-Doc-clarify-the-conditions-of-usable-indexes-for-.patch
Description: Binary data
remove_redundant_check.patch
Description: Binary data
