Hi, On 2023-06-29 13:34:42 -0500, Tristan Partin wrote: > On Thu Jun 29, 2023 at 12:35 PM CDT, Andres Freund wrote: > > Hm. One minor disadvantage of this is that if no c++ compiler was found, you > > can't really see anything about llvm in the the output, nor in > > meson-log.txt, > > making it somewhat hard to figure out why llvm was disabled. > > > > I think something like > > > > elif llvmopt.auto() > > message('llvm requires a C++ compiler') > > endif > > > > Should do the trick? > > Your patch looks great to me. > > > > v5-0011-Pass-feature-option-through-to-required-kwarg.patch > > > > I'm a bit confused how it ended how it's looking like it is right now, but > > ... :) > > > > I'm thinking of merging 0011 and relevant parts of 0012 and 0015 into one. > > Your patch looks great to me.
Pushed these. Thanks! Greetings, Andres Freund