Hi, > I'm afraid it's a bit incomplete: > > ``` > ../src/backend/replication/logical/reorderbuffer.c: In function > ‘ReorderBufferGetTupleBuf’: > ../src/backend/replication/logical/reorderbuffer.c:565:14: error: > ‘ReorderBufferTupleBuf’ has no member named ‘alloc_tuple_size’ > 565 | tuple->alloc_tuple_size = alloc_len; > | ^~ > [829/1882] Compiling C object contrib/xml2/pgxml.so.p/xpath.c.o > ```
Here is the corrected patch. I added it to the nearest CF [1]. > On top of that IMO it doesn't make much sense to keep a one-field > wrapper structure. Perhaps we should get rid of it entirely and just > use HeapTupleData instead. > > Thoughts? Alternatively we could convert ReorderBufferTupleBufData macro to an inlined function. At least it will add some type safety. I didn't change anything in this respect in v2. Feedback from the community would be much appreciated. [1]: https://commitfest.postgresql.org/44/4461/ -- Best regards, Aleksander Alekseev
v2-0001-Remove-unused-fields-in-ReorderBufferTupleBuf.patch
Description: Binary data