On Wed, 27 Sep 2023 at 08:03, Michael Paquier <mich...@paquier.xyz> wrote: > On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote: >> # Allow running this even without --with-python >> PYTHON ?= python >> >> $(srcdir)/unaccent.rules: generate_unaccent_rules.py >> ../../src/common/unicode/UnicodeData.txt Latin-ASCII.xml >> $(PYTHON) $< --unicode-data-file $(word 2,$^) --latin-ascii-file >> $(word 3,$^) >$@ >> >> It use python to run generate_unaccent_rules.py, However, the ?= operator in >> Makefile only check variable is defined or not, but do not check variable is >> empty. Since the PYTHON is defined in src/Makefile.global, so here PYTHON >> get empty when without --with-ptyhon. > > I am not sure that many people run this script frequently so that may > not be worth adding a check for a defined, still empty or incorrect
Yeah, not frequently, however, it already be used by me, since we provide this function, why not make it better? > value, but.. If you were to change the Makefile we use in this path, > how are you suggesting to change it? I provide a patch at bottom of in [1]. Attached here again. diff --git a/contrib/unaccent/Makefile b/contrib/unaccent/Makefile index 652a3e774c..3ff49ba1e9 100644 --- a/contrib/unaccent/Makefile +++ b/contrib/unaccent/Makefile @@ -26,7 +26,9 @@ endif update-unicode: $(srcdir)/unaccent.rules # Allow running this even without --with-python -PYTHON ?= python +ifeq ($(PYTHON),) +PYTHON = python +endif $(srcdir)/unaccent.rules: generate_unaccent_rules.py ../../src/common/unicode/UnicodeData.txt Latin-ASCII.xml $(PYTHON) $< --unicode-data-file $(word 2,$^) --latin-ascii-file $(word 3,$^) >$@ [1] https://www.postgresql.org/message-id/meyp282mb1669f86c0dc7b4dc48489cb0b6...@meyp282mb1669.ausp282.prod.outlook.com -- Regrads, Japin Li ChengDu WenWu Information Technology Co., Ltd.