On Mon, Oct 16, 2023 at 4:00 AM Michael Paquier <mich...@paquier.xyz> wrote: > On Mon, Oct 16, 2023 at 02:47:03AM +0300, Alexander Korotkov wrote: > > The attached revision fixes test failures spotted by > > commitfest.cputube.org. Also, perl scripts passed perltidy. > > Still you've missed a few things. At quick glance: > - The code indentation was off a bit in event_trigger.c. > - 005_login_trigger.pl fails if the code is compiled with > ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS because a WARNING is > reported in test "create tmp objects: err equals". > - 005_sspi.pl is older than the new test 005_login_trigger.pl, could > you rename it with a different number?
You are very fast and sharp eye! Thank you for fixing the indentation. I just pushed fixes for the rest. ------ Regards, Alexander Korotkov