On Tue, Oct 31, 2023 at 11:16:29AM -0400, Bruce Momjian wrote:
> On Wed, Jul 27, 2022 at 09:28:51PM -0700, David G. Johnston wrote:
> > On Wed, Jul 27, 2022 at 8:22 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
> >
> > I wrote:
> > > If EDB isn't adequately filling in the documentation for the behavior
> > > of their packaging, that's on them.
> >
> > Having now looked more closely at the pg_upgrade documentation,
> > I don't think this is exactly EDB's fault; it's text that should
> > never have been there to begin with. ISTM we need to simply rip out
> > lines 431..448 of pgupgrade.sgml, that is all the Windows-specific
> > text starting with
> >
> > For Windows users, you must be logged into an administrative
> > account,
> > and
> >
> > That has got nothing to recommend it: we do not generally provide
> > platform-specific details in these man pages, and to the extent it
> > provides details, those details are likely to be wrong.
> >
> >
> > I mean, we do provide platform-specific details/examples, it's just that
> > platform is a source installed Linux platform (though pathless)
> >
> > Does the avoidance of dealing with other platforms also apply to NET STOP
> > or do
> > you find that an acceptable variance? Or are you suggesting that basically
> > all
> > O/S commands should be zapped? If not, then rewriting 442 to 446 to just be
> > the command seems worthwhile. I'd say pg_upgrade warrants an examples
> > section
> > like pg_basebackup has (though obviously pg_upgrade is procedural).
>
> I have developed the attached patch to remove RUNAS and SET PATH,
> neither of which appear anywhere else in our docs.
Sorry, fixed patch.
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index 46e8a0b746..4f78e0e1c0 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -532,15 +532,9 @@ NET STOP postgresql-&majorversion;
</para>
<para>
- For Windows users, you must be logged into an administrative account, and
- then start a shell as the <literal>postgres</literal> user and set the proper path:
-
-<programlisting>
-RUNAS /USER:postgres "CMD.EXE"
-SET PATH=%PATH%;C:\Program Files\PostgreSQL\&majorversion;\bin;
-</programlisting>
-
- and then run <application>pg_upgrade</application> with quoted directories, e.g.:
+ For Windows users, you must be logged into an administrative account,
+ and then run <application>pg_upgrade</application> with quoted
+ directories, e.g.:
<programlisting>
pg_upgrade.exe
