On Fri, Oct 20, 2023 at 5:33 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Pushed after a round of editorialization -- mostly cosmetic > stuff, except for tweaking some error messages. I shortened the > test cases a bit too, as I thought they were somewhat excessive > to have as a permanent thing.
Thanks Tom. On Tue, Oct 24, 2023 at 2:51 PM Christoph Berg <m...@debian.org> wrote: > > Re: Tommy Pavlicek > > I've added another patch (0002-require_unused_neg_com-v1.patch) that > > prevents using a commutator or negator that's already part of a pair. > > Hmm. I agree with the general idea of adding sanity checks, but this > might be overzealous: I can't add much beyond what Tom said, but I think this does go a bit beyond a sanity check. I forgot to mention it in my previous message, but the main reason I noticed this was because the DELETE operator code cleans up commutator and negator links to the operator being deleted and that code expects each to be part of exactly a pair.