On Sat, Nov 4, 2023 at 7:19 AM Andres Freund <and...@anarazel.de> wrote: > > On 2023-11-03 00:55:00 +0530, Bharath Rupireddy wrote: > > On Wed, Nov 1, 2023 at 4:24 AM Michael Paquier <mich...@paquier.xyz> wrote: > > > > > > On Tue, Oct 31, 2023 at 04:26:18PM +0900, torikoshia wrote: > > > > Yes, calling pg_stat_reset_shared() for all stats types can do what I > > > > wanted > > > > to do. > > > > But calling it with 6 different parameters seems tiresome and I thought > > > > it > > > > would be convenient to have a parameter to delete all cluster-wide > > > > statistics at once. > > > > I may be wrong, but I imagine that it's more common to want to delete > > > > all of > > > > the statistics for an entire cluster rather than just a portion of it. > > Yes, agreed. However, I'd suggest adding pg_stat_reset_shared(), instead of > pg_stat_reset_shared('all') for this purpose.
An overloaded function seems a better choice than another target 'all'. I'm all +1 for it as others seem to concur with the idea of having something to reset all shared stats. > > > If more flexibility is wanted in this function, could it be an option > > > to consider a flavor like pg_stat_reset_shared(text[]), where it is > > > possible to specify a list of shared stats types to reset? Perhaps > > > there are no real use cases for it, just wanted to mention it anyway > > > regarding the fact that it could have benefits to refactor this code > > > to use a bitwise operator for its internals with bit flags for each > > > type. > > I don't think there is much point in such an API - if the caller actually > wants to delete individual stats, it's not too hard to loop. -1 for text[] version. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com