Hi Euler, On Fri, Jan 12, 2024 at 6:16 AM Euler Taveira <eu...@eulerto.com> wrote: > > On Thu, Jan 11, 2024, at 9:18 AM, Hayato Kuroda (Fujitsu) wrote: > > I have been concerned that the patch has not been tested by cfbot due to the > application error. Also, some comments were raised. Therefore, I created a > patch > to move forward. > > > Let me send an updated patch to hopefully keep the CF bot happy. The following > items are included in this patch: > > * drop physical replication slot if standby is using one [1]. > * cleanup small changes (copyright, .gitignore) [2][3] > * fix getopt_long() options [2] > * fix format specifier for some messages > * move doc to Server Application section [4] > * fix assert failure > * ignore duplicate database names [2] > * store subscriber server log into a separate file > * remove MSVC support > > I'm still addressing other reviews and I'll post another version that includes > it soon. > > [1] > https://www.postgresql.org/message-id/e02a2c17-22e5-4ba6-b788-de696ab74f1e%40app.fastmail.com > [2] > https://www.postgresql.org/message-id/CALDaNm1joke42n68LdegN5wCpaeoOMex2EHcdZrVZnGD3UhfNQ%40mail.gmail.com > [3] > https://www.postgresql.org/message-id/TY3PR01MB98895BA6C1D72CB8582CACC4F5682%40TY3PR01MB9889.jpnprd01.prod.outlook.com > [4] > https://www.postgresql.org/message-id/TY3PR01MB988978C7362A101927070D29F56A2%40TY3PR01MB9889.jpnprd01.prod.outlook.com >
+ <refnamediv> + <refname>pg_subscriber</refname> + <refpurpose>create a new logical replica from a standby server</refpurpose> + </refnamediv> I'm a bit confused about this wording because we are converting a standby to a logical replica but not creating a new logical replica and leaving the standby as is. How about: <refpurpose>convert a standby replica to a logical replica</refpurpose> + <para> + The <application>pg_subscriber</application> should be run at the target + server. The source server (known as publisher server) should accept logical + replication connections from the target server (known as subscriber server). + The target server should accept local logical replication connection. + </para> What is *local logical replication*? I can't find any clue in the patch, can you give me some hint? > > -- > Euler Taveira > EDB https://www.enterprisedb.com/ > -- Regards Junwang Zhao