Hi, > > But why didn't you pursue your idea of getting rid of the wrapper > > structure ReorderBufferTupleBuf which after this patch will have just > > one member? I think there could be hassles in backpatching bug-fixes > > in some cases but in the longer run it would make the code look clean. > > Indeed. In fact turned out that I suggested the same above but > apparently forgot: > > > On top of that IMO it doesn't make much sense to keep a one-field > > wrapper structure. Perhaps we should get rid of it entirely and just > > use HeapTupleData instead. > > After actually trying the refactoring I agree that the code becomes > cleaner and it's going to be beneficial in the long run. Here is the > patch.
I did a mistake in v4: ``` - alloc_len = tuple_len + SizeofHeapTupleHeader; + alloc_len = tuple_len + HEAPTUPLESIZE; ``` Here is the corrected patch. -- Best regards, Aleksander Alekseev
v5-0001-Remove-ReorderBufferTupleBuf-structure.patch
Description: Binary data
