Nathan Bossart <nathandboss...@gmail.com> writes: > On Thu, Feb 08, 2024 at 11:59:54AM -0800, Andres Freund wrote: >> I'd put these static inlines into common/int.h. I don't think this is common >> enough to warrant being in c.h. Probably also doesn't hurt to have a not >> quite >> as generic name as INT_CMP, I'd not be too surprised if that's defined in >> some >> library. >> >> I think it's worth following int.h's pattern of including [s]igned/[u]nsigned >> in the name, an efficient implementation for signed might not be the same as >> for unsigned. And if we use static inlines, we need to do so for correct >> semantics anyway.
> Seems reasonable to me. +1 here also. regards, tom lane