On Wed, Oct 4, 2023 at 9:12 PM James Coleman <jtc...@gmail.com> wrote: > All right, attached is a v3 which attempts to fix the wrong > information with an economy of words. I may at some point submit a > separate patch that adds a broader pruning section, but this at least > brings the docs inline with reality insofar as they address it.
I don't think this is as good as what I proposed back on October 2nd. IMHO, that version does a good job making the text accurate and clear, and is directly responsive to your original complaint, namely, that the root of the HOT chain can't be removed. But this version seems to contain a number of incidental changes that are unrelated to that point, e.g. "old versions" -> "old, no longer visible versions", "can be completely removed" -> "may be pruned", and the removal of the sentence "In summary, heap-only tuple updates can only be created - if columns used by indexes are not updated" which AFAICT is both completely correct as-is and unrelated to the original complaint. Maybe I shouldn't be, but I'm slightly frustrated here. I thought I had proposed an alternative which you found acceptable, but then you proposed several more versions that did other things instead, and I never really understood why we couldn't just adopt the version that you seemed to think was OK. If there's a problem with that, say what it is. If there's not, let's do that and move on. -- Robert Haas EDB: http://www.enterprisedb.com