On Sun, 2024-03-17 at 23:33 -0400, Corey Huinker wrote: > > A few TAP tests are still failing and I haven't been able to diagnose > why, though the failures in parallel dump seem to be that it tries to > import stats on indexes that haven't been created yet, which is odd > because I sent the dependency.
>From testrun/pg_dump/002_pg_dump/log/regress_log_002_pg_dump, search for the "not ok" and then look at what it tried to do right before that. I see: pg_dump: error: prepared statement failed: ERROR: syntax error at or near "%" LINE 1: ..._histogram => %L::real[]) coalesce($2, format('%I.%I', a.nsp... > All those changes are available in the patches attached. How about if you provided "get" versions of the functions that return a set of rows that match what the "set" versions expect? That would make 0001 essentially a complete feature itself. I think it would also make the changes in pg_dump simpler, and the tests in 0001 a lot simpler. Regards, Jeff Davis