On Thu, Mar 21, 2024 at 12:40 PM Bertrand Drouvot
<bertranddrouvot...@gmail.com> wrote:
>
> v13-0001 looks good to me. The only Nit (that I've mentioned up-thread) is 
> that
> in the pg_replication_slots view, the invalidation_reason is "far away" from 
> the
> conflicting field. I understand that one could query the fields individually 
> but
> when describing the view or reading the doc, it seems more appropriate to see
> them closer. Also as "failover" and "synced" are also new in version 17, there
> is no risk to break order by "17,18" kind of queries (which are the failover
> and sync positions).

Hm, yeah, I can change that in the next version of the patches. Thanks.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com


Reply via email to