On Tue, Mar 26, 2024 at 4:35 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > If we just sync inactive_since value for synced slots while in > recovery from the primary, so be it. Why do we need to update it to > the current time when the slot is being created? We don't expose slot > creation time, no? Aren't we fine if we just sync the value from > primary and document that fact? After the promotion, we can reset it > to the current time so that it gets its own time.
I'm attaching v24 patches. It implements the above idea proposed upthread for synced slots. I've now separated s/last_inactive_time/inactive_since and synced slots behaviour. Please have a look. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v24-0001-Use-less-confusing-name-for-slot-s-last_inactive.patch
Description: Binary data
v24-0002-Maintain-inactive_since-for-synced-slots-correct.patch
Description: Binary data
v24-0003-Allow-setting-inactive_timeout-for-replication-s.patch
Description: Binary data
v24-0004-Add-inactive_timeout-based-replication-slot-inva.patch
Description: Binary data
