On Wed, 27 Mar 2024 at 20:10, Maciek Sakrejda <m.sakre...@gmail.com> wrote: > > On Wed, Mar 27, 2024, 11:46 Robert Haas <robertmh...@gmail.com> wrote: >> >> On Wed, Mar 27, 2024 at 1:12 PM Isaac Morland <isaac.morl...@gmail.com> >> wrote: >> > On Wed, 27 Mar 2024 at 13:05, Greg Sabino Mullane <htamf...@gmail.com> >> > wrote: >> >>> The purpose of the setting is to prevent <emphasis>accidental</emphasis> >> >>> modifications via <literal>ALTER SYSTEM</literal> in environments where >> >> The emphasis on 'accidental' seems a bit heavy here, and odd. Surely, >> >> just "to prevent modifications via ALTER SYSTEM in environments where..." >> >> is enough? >> > Not necessarily disagreeing, but it's very important nobody ever mistake >> > this for a security feature. I don't know if the extra word "accidental" >> > is necessary, but I think that's the motivation. >> >> I think the emphasis is entirely warranted in this case. > > +1. And while "non-malicious" may technically be more correct, I don't think > it's any clearer.
Attached is a new version of the patch with some sentences reworded. I changed accidentally to mistakenly (which still has emphasis). And I hope with the rewording it's now clearer to the reader why that emphasis is there.
v9-0001-Add-allow_alter_system-GUC.patch
Description: Binary data
